Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic message for parser error of config file #4853

Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Nov 2, 2018

Now that we move the config file to the rtd code, and that we do all the validation stuff inside the config module, this message isn't correct, because a user can build their project using only the config from the web admin, but internally we use the config module for some validations.

Fix #4401

@stsewd stsewd requested review from humitos and Nov 2, 2018
@codecov
Copy link

@codecov codecov bot commented Nov 2, 2018

Codecov Report

Merging #4853 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4853   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files         158      158           
  Lines        9990     9990           
  Branches     1262     1262           
=======================================
  Hits         7634     7634           
  Misses       2016     2016           
  Partials      340      340
Impacted Files Coverage Δ
readthedocs/doc_builder/exceptions.py 100% <ø> (ø) ⬆️

@ericholscher ericholscher merged commit 96cbae7 into readthedocs:master Nov 5, 2018
3 checks passed
@stsewd stsewd deleted the generic-msg-for-config-file branch Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants