Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'VerisionLockedTimeout' to 'VersionLockedError' in comment. #4859

Merged

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Nov 4, 2018

Fixes a typo.

Copy link
Member

@RichardLitt RichardLitt left a comment

Looks good to me. Travis error unrelated.

stsewd
stsewd approved these changes Nov 5, 2018
Copy link
Member

@stsewd stsewd left a comment

Failure is unrelated, but looks like a flaky test, maybe?

@codecov
Copy link

@codecov codecov bot commented Nov 5, 2018

Codecov Report

Merging #4859 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4859   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files         158      158           
  Lines        9990     9990           
  Branches     1262     1262           
=======================================
  Hits         7634     7634           
  Misses       2016     2016           
  Partials      340      340
Impacted Files Coverage Δ
readthedocs/projects/tasks.py 69.31% <ø> (ø) ⬆️

@ericholscher ericholscher merged commit 8fb8438 into readthedocs:master Nov 5, 2018
3 checks passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 5, 2018

Thanks @dojutsu-user -- you've been doing a bunch of great work recently!

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Nov 5, 2018

@ericholscher Thanks for the appreciation and thanks to RTD community for helping me so much.

@dojutsu-user dojutsu-user deleted the fix-typo-in-comments-tasks branch Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants