Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration name on modified date migration #4867

Merged
merged 2 commits into from Nov 5, 2018
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 5, 2018

No description provided.

stsewd
stsewd approved these changes Nov 5, 2018
@@ -8,7 +8,7 @@
class Migration(migrations.Migration):

dependencies = [
('projects', '0029_add_additional_languages'),
('projects', '0030_add_modified_date_importedfile'),
Copy link
Member

@stsewd stsewd Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, I approved, but this should be 0030_change-max-length-project

Loading

Copy link
Member Author

@ericholscher ericholscher Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, indeed sigh

Loading

Copy link
Member Author

@ericholscher ericholscher Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing CI caught it :D

Loading

@codecov
Copy link

@codecov codecov bot commented Nov 5, 2018

Codecov Report

Merging #4867 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4867   +/-   ##
=======================================
  Coverage   36.31%   36.31%           
=======================================
  Files         158      158           
  Lines        9993     9993           
  Branches     1262     1262           
=======================================
  Hits         3629     3629           
  Misses       6350     6350           
  Partials       14       14

Loading

@@ -8,7 +8,7 @@
class Migration(migrations.Migration):

dependencies = [
('projects', '0029_add_additional_languages'),
('projects', '0030_change-max-length-project'),
Copy link
Member

@stsewd stsewd Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just copied the filename from github and it got truncated, the complete filename is 0030_change-max-length-project-slug

Loading

Copy link
Member

@stsewd stsewd Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

Copy link
Member Author

@ericholscher ericholscher Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quietly rewrites history like it never happened

Loading

stsewd
stsewd approved these changes Nov 5, 2018
@ericholscher ericholscher merged commit afd7dd9 into master Nov 5, 2018
3 checks passed
Loading
@stsewd stsewd deleted the fix-migration branch Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants