Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django-guardian settings #4871

Merged

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Nov 6, 2018

RTD is using django-guardian (version: 1.4.9).

ANONYMOUS_USER_ID is deprecated (changelog) in 1.4.2

According to the new configurable variables, we should use ANONYMOUS_USER_NAME, whose default value is already set to "AnonymousUser" (Read here). So, I think that there is no need to set it again in our settings/base.py

@codecov
Copy link

@codecov codecov bot commented Nov 6, 2018

Codecov Report

Merging #4871 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4871   +/-   ##
=======================================
  Coverage   76.47%   76.47%           
=======================================
  Files         158      158           
  Lines        9993     9993           
  Branches     1262     1262           
=======================================
  Hits         7642     7642           
  Misses       2009     2009           
  Partials      342      342

Copy link
Member

@ericholscher ericholscher left a comment

Simple enough. 👍

@ericholscher ericholscher merged commit c9b25c4 into readthedocs:master Nov 7, 2018
3 checks passed
@dojutsu-user dojutsu-user deleted the update-django-guardian-settings branch Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants