Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if latest exists before updating identifier #4873

Merged
merged 1 commit into from Nov 6, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Nov 6, 2018

Related https://sentry.io/read-the-docs/readthedocs-org/issues/754432613/?query=is:unresolved

@codecov
Copy link

@codecov codecov bot commented Nov 6, 2018

Codecov Report

Merging #4873 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4873      +/-   ##
==========================================
- Coverage    76.5%   76.46%   -0.05%     
==========================================
  Files         158      158              
  Lines        9997     9997              
  Branches     1262     1262              
==========================================
- Hits         7648     7644       -4     
- Misses       2006     2011       +5     
+ Partials      343      342       -1
Impacted Files Coverage Δ
readthedocs/projects/models.py 85.1% <100%> (-0.43%) ⬇️
readthedocs/projects/exceptions.py 84.21% <0%> (-5.27%) ⬇️
readthedocs/vcs_support/backends/git.py 80.35% <0%> (-0.6%) ⬇️

@ericholscher ericholscher merged commit fd73963 into readthedocs:master Nov 6, 2018
3 checks passed
@stsewd stsewd deleted the dont-log-exc-on-save branch Nov 6, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Nov 6, 2018

Sentry issue: READTHEDOCS-ORG-EAB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants