Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable django guardian warning #4892

Merged

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Nov 11, 2018

This is of very low priority.
But this warning pops up everytime in the build

screenshot from 2018-11-11 23-54-19

Fixes #4861

@codecov
Copy link

@codecov codecov bot commented Nov 11, 2018

Codecov Report

Merging #4892 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4892   +/-   ##
======================================
  Coverage    76.6%   76.6%           
======================================
  Files         158     158           
  Lines       10043   10043           
  Branches     1268    1268           
======================================
  Hits         7693    7693           
  Misses       2008    2008           
  Partials      342     342

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Nov 11, 2018

@stsewd
Can you please review it.

@stsewd stsewd requested a review from Nov 12, 2018
@@ -48,6 +48,8 @@ def DATABASES(self): # noqa
'test:8000',
)

SILENCED_SYSTEM_CHECKS = ['fields.W342', 'guardian.W001']
Copy link
Member

@stsewd stsewd Nov 12, 2018

Not sure that we need to duplicate this here, I believe the configs got merged with the ones from base

Copy link
Member Author

@dojutsu-user dojutsu-user Nov 12, 2018

When i tested this yesterday, it was not working. But somehow it is working fine now.
So, i have removed it from here.
Thanks for this.

@agjohnson agjohnson added this to the Cleanup milestone Nov 13, 2018
@ericholscher ericholscher merged commit a3f561d into readthedocs:master Dec 26, 2018
3 checks passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Dec 26, 2018

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants