Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade stripe Python package to the latest version #4904

Merged
merged 1 commit into from Nov 19, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Nov 15, 2018

@humitos humitos requested a review from Nov 15, 2018
@@ -222,7 +222,7 @@ def test_update_subscription_plan(self):
mock.ANY,
mock.ANY),
mock.call('post',
'/v1/customers/cus_12345/subscriptions/sub_12345',
'/v1/subscriptions/sub_12345',
Copy link
Member Author

@humitos humitos Nov 15, 2018

@@ -69,7 +69,7 @@ def get_subscription(self):
customer = self.get_customer()

# TODO get the first subscription more intelligently
subscriptions = customer.subscriptions.all(limit=5)
subscriptions = customer.subscriptions.list(limit=5)
Copy link
Member Author

@humitos humitos Nov 15, 2018

@codecov
Copy link

@codecov codecov bot commented Nov 15, 2018

Codecov Report

Merging #4904 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #4904   +/-   ##
=======================================
  Coverage   76.65%   76.65%           
=======================================
  Files         158      158           
  Lines       10057    10057           
  Branches     1269     1269           
=======================================
  Hits         7709     7709           
  Misses       2007     2007           
  Partials      341      341
Impacted Files Coverage Δ
readthedocs/payments/forms.py 60.49% <100%> (ø) ⬆️
readthedocs/gold/forms.py 95% <100%> (ø) ⬆️

Copy link
Contributor

@agjohnson agjohnson left a comment

This makes sense. Definitely something to test out more on our next QA pass, I'll add this to our list

@humitos humitos merged commit 4031b90 into master Nov 19, 2018
3 checks passed
@humitos humitos deleted the humitos/stripe/upgrade branch Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants