Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .exists in queryset #4927

merged 1 commit into from Nov 27, 2018


Copy link

@stsewd stsewd commented Nov 26, 2018

The queryset gets evaluated here, we don't need the whole objects

@stsewd stsewd requested a review from Nov 26, 2018
Copy link

@codecov codecov bot commented Nov 26, 2018

Codecov Report

Merging #4927 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #4927   +/-   ##
  Coverage   76.75%   76.75%           
  Files         158      158           
  Lines       10048    10048           
  Branches     1265     1265           
  Hits         7712     7712           
  Misses       1995     1995           
  Partials      341      341
Impacted Files Coverage Δ
readthedocs/builds/ 86.51% <100%> (ø) ⬆️

@ericholscher ericholscher merged commit 47bc26e into readthedocs:master Nov 27, 2018
3 checks passed
@stsewd stsewd deleted the use-exists-in-qs branch Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants