Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated and dead code #4929

Merged
merged 2 commits into from Dec 3, 2018
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Nov 27, 2018

Close #3540

I did a couple of builds and everything looks good.

if status > 0:
log.error('Could not symlink path: status=%d error=%s',
status, stderr)
result = self.environment.run('ln', '-nsf', docs_dir, symlink)
@codecov
Copy link

@codecov codecov bot commented Nov 27, 2018

Codecov Report

Merging #4929 into master will increase coverage by 0.1%.
The diff coverage is 91.66%.

@@            Coverage Diff            @@
##           master    #4929     +/-   ##
=========================================
+ Coverage   76.75%   76.86%   +0.1%     
=========================================
  Files         158      158             
  Lines       10048    10005     -43     
  Branches     1265     1257      -8     
=========================================
- Hits         7712     7690     -22     
+ Misses       1995     1979     -16     
+ Partials      341      336      -5
Impacted Files Coverage Δ
readthedocs/projects/utils.py 59.09% <100%> (+4.54%) ⬆️
readthedocs/core/symlink.py 94.51% <91.3%> (+0.03%) ⬆️

@stsewd stsewd requested a review from Nov 27, 2018
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 27, 2018

This is really annoying/hard to review because of the linting fixes along with code changes.

@stsewd stsewd force-pushed the remove-repeated-code branch from 4290370 to 2b5b875 Nov 27, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Nov 27, 2018

Sorry, I have divided the PR into two commits, 2b5b875 contains the real change

Copy link
Member

@ericholscher ericholscher left a comment

Looks good. Yay for deleting another run method :D

@humitos humitos merged commit 273776c into readthedocs:master Dec 3, 2018
3 checks passed
@stsewd stsewd deleted the remove-repeated-code branch Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants