Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install latest version of pip #4938

Merged
merged 5 commits into from Dec 4, 2018
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Nov 29, 2018

Closes #4823

@stsewd
Copy link
Member Author

@stsewd stsewd commented Nov 29, 2018

There is still the decision if use a feature flag to install the latest instead of the version that is pinned.

@stsewd stsewd requested a review from Nov 29, 2018
@codecov
Copy link

@codecov codecov bot commented Nov 29, 2018

Codecov Report

Merging #4938 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4938      +/-   ##
==========================================
+ Coverage   76.93%   76.94%   +<.01%     
==========================================
  Files         158      158              
  Lines       10039    10042       +3     
  Branches     1259     1259              
==========================================
+ Hits         7724     7727       +3     
  Misses       1981     1981              
  Partials      334      334
Impacted Files Coverage Δ
readthedocs/doc_builder/python_environments.py 83.44% <100%> (+0.46%) ⬆️
readthedocs/restapi/views/model_views.py 94.15% <0%> (-0.04%) ⬇️


# Install latest pip first,
# so it is used when installing the other requirements.
cmd = pip_install_cmd + ['pip==18.1']
Copy link
Member

@ericholscher ericholscher Nov 30, 2018

Do we really expect to update this regularly? Feels like we should probably just call it with --upgrade, but I also worry about being exposed to pip bugs on release :/

Copy link
Member Author

@stsewd stsewd Nov 30, 2018

Well, the release history looks good https://pypi.org/project/pip/#history. Not sure, I'm also worry about not having control of the version in case a bug comes up from pip.

Copy link
Member

@humitos humitos Dec 3, 2018

pip is a really mature piece of software with active development. All the python ecosystem relies on it. I think it will be better to just unpin it and rely on them.

The case would be different if we are talking about a different package.

Copy link
Member

@humitos humitos left a comment

Changes look good.

I'd unpin pip and merge.

readthedocs/doc_builder/python_environments.py Outdated Show resolved Hide resolved

# Install latest pip first,
# so it is used when installing the other requirements.
cmd = pip_install_cmd + ['pip==18.1']
Copy link
Member

@humitos humitos Dec 3, 2018

pip is a really mature piece of software with active development. All the python ecosystem relies on it. I think it will be better to just unpin it and rely on them.

The case would be different if we are talking about a different package.

@ericholscher ericholscher merged commit 50bb883 into readthedocs:master Dec 4, 2018
3 checks passed
@stsewd stsewd deleted the install-latest-pip branch Dec 4, 2018
@stsewd stsewd mentioned this pull request Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants