Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt code to remove and ignore warnings #4953

Merged
merged 5 commits into from Dec 4, 2018
Merged

Conversation

@humitos
Copy link
Member

@humitos humitos commented Dec 4, 2018

Adapt some parts of the code to remove warnings and ignore Django 2.0 and external dependencies warnings also.

We do not control external dependencies warnings and we can't upgrade them. We rely on them to update their code before we migrate to Django 2.0. Before migrating to Django 2.0 we will need to remove this ignore filters and run all the tests to check what dependencies are still not compatible. In the meantime, we remove all this garbage from the summary output.

humitos added 5 commits Dec 4, 2018
@codecov
Copy link

@codecov codecov bot commented Dec 4, 2018

Codecov Report

Merging #4953 into master will decrease coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #4953      +/-   ##
==========================================
- Coverage   76.93%   76.93%   -0.01%     
==========================================
  Files         158      158              
  Lines       10039    10038       -1     
  Branches     1259     1259              
==========================================
- Hits         7724     7723       -1     
  Misses       1981     1981              
  Partials      334      334
Impacted Files Coverage Δ
readthedocs/core/utils/tasks/permission_checks.py 28.57% <0%> (ø) ⬆️
readthedocs/search/views.py 74.41% <0%> (ø) ⬆️
readthedocs/projects/views/public.py 69.46% <0%> (ø) ⬆️
readthedocs/restapi/serializers.py 97.43% <0%> (ø) ⬆️
readthedocs/api/utils.py 56.25% <0%> (ø) ⬆️
readthedocs/restapi/views/integrations.py 91.76% <100%> (ø) ⬆️
readthedocs/oauth/querysets.py 100% <100%> (ø) ⬆️
readthedocs/notifications/storages.py 82.53% <100%> (ø) ⬆️
readthedocs/restapi/views/model_views.py 94.15% <100%> (-0.04%) ⬇️
readthedocs/restapi/urls.py 80% <100%> (ø) ⬆️
... and 2 more

Loading

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Dec 4, 2018

Codecov Report

Merging #4953 into master will decrease coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #4953      +/-   ##
==========================================
- Coverage   76.93%   76.93%   -0.01%     
==========================================
  Files         158      158              
  Lines       10039    10038       -1     
  Branches     1259     1259              
==========================================
- Hits         7724     7723       -1     
  Misses       1981     1981              
  Partials      334      334
Impacted Files Coverage Δ
readthedocs/core/utils/tasks/permission_checks.py 28.57% <0%> (ø) ⬆️
readthedocs/search/views.py 74.41% <0%> (ø) ⬆️
readthedocs/projects/views/public.py 69.46% <0%> (ø) ⬆️
readthedocs/restapi/serializers.py 97.43% <0%> (ø) ⬆️
readthedocs/api/utils.py 56.25% <0%> (ø) ⬆️
readthedocs/restapi/views/integrations.py 91.76% <100%> (ø) ⬆️
readthedocs/oauth/querysets.py 100% <100%> (ø) ⬆️
readthedocs/notifications/storages.py 82.53% <100%> (ø) ⬆️
readthedocs/restapi/views/model_views.py 94.15% <100%> (-0.04%) ⬇️
readthedocs/restapi/urls.py 80% <100%> (ø) ⬆️
... and 2 more

Loading

@humitos humitos requested a review from Dec 4, 2018
@humitos
Copy link
Member Author

@humitos humitos commented Dec 4, 2018

All tests passed, but codecov fail for some reason. I don't care too much though, because I didn't add new code or modify logic.

Loading

@ericholscher ericholscher merged commit 213dabe into master Dec 4, 2018
1 of 3 checks passed
Loading
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Dec 4, 2018

💯

Loading

@humitos humitos deleted the humitos/upgrade/warnings branch Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants