Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set LANG environment variables #4954

Merged
merged 1 commit into from Dec 4, 2018
Merged

Conversation

@humitos
Copy link
Member

@humitos humitos commented Dec 4, 2018

LANG=C means ASCII and that's why unicode branches/tag tests are failing.

LANG=en_US.UTF-8 is the value that we are using in production. So, I think it's important to use this value in our test suite.

@codecov
Copy link

@codecov codecov bot commented Dec 4, 2018

Codecov Report

Merging #4954 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4954   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files         158      158           
  Lines       10039    10039           
  Branches     1259     1259           
=======================================
  Hits         7724     7724           
  Misses       1981     1981           
  Partials      334      334

Loading

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Dec 4, 2018

Codecov Report

Merging #4954 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4954   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files         158      158           
  Lines       10039    10039           
  Branches     1259     1259           
=======================================
  Hits         7724     7724           
  Misses       1981     1981           
  Partials      334      334

Loading

@humitos humitos requested a review from Dec 4, 2018
@humitos
Copy link
Member Author

@humitos humitos commented Dec 4, 2018

NOTE: this change makes my local tests about git tags/branches to pass without problem.

Loading

LANG=C means ASCII and that's why unicode branches/tag tests are
failing.
@humitos humitos force-pushed the humitos/tox/lang-variable branch from 9b30f68 to 87397f2 Dec 4, 2018
@ericholscher ericholscher merged commit 90b6af8 into master Dec 4, 2018
3 checks passed
Loading
@stsewd stsewd deleted the humitos/tox/lang-variable branch Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants