Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for send_notifications on VersionLockedError #4958

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Dec 5, 2018

Fixes #4840
This test checks that no notification is sent if the Version is locked.

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Dec 5, 2018

I am not able to write test for it. Any help would be nice.

Loading

@codecov
Copy link

@codecov codecov bot commented Dec 5, 2018

Codecov Report

Merging #4958 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4958      +/-   ##
==========================================
+ Coverage    76.8%   76.84%   +0.04%     
==========================================
  Files         158      158              
  Lines        9937     9937              
  Branches     1241     1241              
==========================================
+ Hits         7632     7636       +4     
+ Misses       1973     1971       -2     
+ Partials      332      330       -2
Impacted Files Coverage Δ
readthedocs/projects/tasks.py 71.4% <0%> (+0.2%) ⬆️
readthedocs/doc_builder/environments.py 87.87% <0%> (+0.8%) ⬆️

Loading

@stsewd
Copy link
Member

@stsewd stsewd commented Dec 5, 2018

I'm not sure what you mean, I already see a test here. If you mean the codecov failure, that is because of the test code, you can see the codecov report here https://codecov.io/gh/rtfd/readthedocs.org/pull/4958/diff (the lines with dark red marks are missing coverage)

Loading

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Dec 5, 2018

@stsewd
The test in this PR is not working as of now (that test is my attemp to write the required test)
Actually I wanted to test these lines

https://github.com/rtfd/readthedocs.org/blob/50bb883769328afc33a699ff93d9ccd8488ad1b1/readthedocs/projects/tasks.py#L472-L477

Loading

@dojutsu-user dojutsu-user changed the title [WIP] Add test case for send_notifications on VersionLockedError Add test case for send_notifications on VersionLockedError Dec 5, 2018
@agjohnson agjohnson added this to the Test improvements milestone Dec 5, 2018
@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Dec 6, 2018

I think, it's ready for review.

Loading

@RichardLitt
Copy link
Member

@RichardLitt RichardLitt commented Dec 11, 2018

@agjohnson Can you explicitly specify what information you need before reviewing this?

Loading

@ericholscher ericholscher merged commit ee2d784 into readthedocs:master Jan 10, 2019
3 checks passed
Loading
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 10, 2019

This looks 💯

Loading

@dojutsu-user dojutsu-user deleted the test-send-notif-version-locked-error branch Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants