Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for a django-storages bug #4963

Merged
merged 1 commit into from Dec 5, 2018

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Dec 5, 2018

Django-storages has a bug in the AzureStorage that has problems with ? and = in URLs. This gets triggered when these files are post-processed with Django's ManifestFilesMixin

@davidfischer davidfischer requested a review from Dec 5, 2018
@codecov
Copy link

@codecov codecov bot commented Dec 5, 2018

Codecov Report

Merging #4963 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4963   +/-   ##
======================================
  Coverage    76.8%   76.8%           
======================================
  Files         158     158           
  Lines        9937    9937           
  Branches     1241    1241           
======================================
  Hits         7632    7632           
  Misses       1973    1973           
  Partials      332     332

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Dec 5, 2018

Codecov Report

Merging #4963 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4963   +/-   ##
======================================
  Coverage    76.8%   76.8%           
======================================
  Files         158     158           
  Lines        9937    9937           
  Branches     1241    1241           
======================================
  Hits         7632    7632           
  Misses       1973    1973           
  Partials      332     332

@ericholscher ericholscher merged commit 7027fd5 into master Dec 5, 2018
3 checks passed
@stsewd stsewd deleted the davidfischer/workaround-storages-609 branch Dec 6, 2018
src: url('../fonts/fontawesome-webfont.eot?v=4.4.0');
src: url('../fonts/fontawesome-webfont.eot?#iefix&v=4.4.0') format('embedded-opentype'), url('../fonts/fontawesome-webfont.woff?v=4.4.0') format('woff'), url('../fonts/fontawesome-webfont.ttf?v=4.4.0') format('truetype'), url('../fonts/fontawesome-webfont.svg?v=4.4.0#fontawesomeregular') format('svg');
src: url('../fonts/fontawesome-webfont.eot');
src: url('../fonts/fontawesome-webfont.eot?#iefix') format('embedded-opentype'), url('../fonts/fontawesome-webfont.woff') format('woff'), url('../fonts/fontawesome-webfont.ttf') format('truetype'), url('../fonts/fontawesome-webfont.svg') format('svg');
Copy link
Member

@humitos humitos Dec 6, 2018

This URL still has a ? on it. Isn't that a problem?

Copy link
Contributor Author

@davidfischer davidfischer Dec 6, 2018

No. Hashes seem to get handled properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants