Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated "models.permalink" #4975

Merged

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Dec 9, 2018

django.db.models.permalink() is deprecated 4-5 years ago (ticket #18974) and it is now completely removed in Django 2.1 (Deprecation Timeline for Django 2.1)

@codecov
Copy link

@codecov codecov bot commented Dec 9, 2018

Codecov Report

Merging #4975 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4975   +/-   ##
======================================
  Coverage    76.8%   76.8%           
======================================
  Files         158     158           
  Lines        9937    9937           
  Branches     1241    1241           
======================================
  Hits         7632    7632           
  Misses       1973    1973           
  Partials      332     332
Impacted Files Coverage Δ
readthedocs/builds/models.py 78.83% <100%> (ø) ⬆️
readthedocs/core/models.py 74.19% <100%> (ø) ⬆️

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Dec 9, 2018

Codecov Report

Merging #4975 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4975   +/-   ##
======================================
  Coverage    76.8%   76.8%           
======================================
  Files         158     158           
  Lines        9937    9937           
  Branches     1241    1241           
======================================
  Hits         7632    7632           
  Misses       1973    1973           
  Partials      332     332
Impacted Files Coverage Δ
readthedocs/builds/models.py 78.83% <100%> (ø) ⬆️
readthedocs/core/models.py 74.19% <100%> (ø) ⬆️

stsewd
stsewd approved these changes Dec 11, 2018
@ericholscher ericholscher merged commit 070458c into readthedocs:master Dec 26, 2018
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants