Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated imports from "urlresolvers" #4976

Merged

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Dec 9, 2018

django.core.urlresolvers module is deprecated in Django 1.10 (Misc. updates of Django 1.10) and is completely removed in Django 2.0 (Deprecation removed in 2.0).

Also, I didn't find docs for django.urls.base but I have verified that get_urlconf() and set_urlconf() are present in django.urls.base

@codecov
Copy link

@codecov codecov bot commented Dec 9, 2018

Codecov Report

Merging #4976 into master will not change coverage.
The diff coverage is 94.11%.

@@          Coverage Diff           @@
##           master   #4976   +/-   ##
======================================
  Coverage    76.8%   76.8%           
======================================
  Files         158     158           
  Lines        9937    9937           
  Branches     1241    1241           
======================================
  Hits         7632    7632           
  Misses       1973    1973           
  Partials      332     332
Impacted Files Coverage Δ
readthedocs/projects/models.py 85.55% <100%> (ø) ⬆️
readthedocs/gold/views.py 66.17% <100%> (ø) ⬆️
readthedocs/oauth/notifications.py 83.33% <100%> (ø) ⬆️
readthedocs/oauth/models.py 78.75% <100%> (ø) ⬆️
readthedocs/projects/views/private.py 80.05% <100%> (ø) ⬆️
readthedocs/projects/views/public.py 69.46% <100%> (ø) ⬆️
readthedocs/core/middleware.py 84.55% <100%> (ø) ⬆️
readthedocs/oauth/services/gitlab.py 52.56% <100%> (ø) ⬆️
readthedocs/restapi/views/task_views.py 87.87% <100%> (ø) ⬆️
readthedocs/profiles/views.py 88.13% <100%> (ø) ⬆️
... and 6 more

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Dec 9, 2018

Codecov Report

Merging #4976 into master will not change coverage.
The diff coverage is 94.11%.

@@          Coverage Diff           @@
##           master   #4976   +/-   ##
======================================
  Coverage    76.8%   76.8%           
======================================
  Files         158     158           
  Lines        9937    9937           
  Branches     1241    1241           
======================================
  Hits         7632    7632           
  Misses       1973    1973           
  Partials      332     332
Impacted Files Coverage Δ
readthedocs/projects/models.py 85.55% <100%> (ø) ⬆️
readthedocs/gold/views.py 66.17% <100%> (ø) ⬆️
readthedocs/oauth/notifications.py 83.33% <100%> (ø) ⬆️
readthedocs/oauth/models.py 78.75% <100%> (ø) ⬆️
readthedocs/projects/views/private.py 80.05% <100%> (ø) ⬆️
readthedocs/projects/views/public.py 69.46% <100%> (ø) ⬆️
readthedocs/core/middleware.py 84.55% <100%> (ø) ⬆️
readthedocs/oauth/services/gitlab.py 52.56% <100%> (ø) ⬆️
readthedocs/restapi/views/task_views.py 87.87% <100%> (ø) ⬆️
readthedocs/profiles/views.py 88.13% <100%> (ø) ⬆️
... and 6 more

stsewd
stsewd approved these changes Dec 11, 2018
Copy link
Member

@humitos humitos left a comment

Yay! Thanks. I hate those warnings appearing all the time ;)

@humitos humitos merged commit cd6e821 into readthedocs:master Dec 12, 2018
3 checks passed
@dojutsu-user dojutsu-user deleted the remove-deprecated-urlresolvers branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants