Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify DB field for container_time_limit to be an integer #4979

Merged
merged 1 commit into from Dec 10, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Dec 10, 2018

This could also be fixed by casting this line

https://github.com/rtfd/readthedocs.org/blob/2979d1fb1ce2047ed64f9e2291632a38b3714883/readthedocs/projects/models.py#L613

but it will break in another places in the end. So, I think it's better to make the container_time_limit an IntegerField.

Sentry: https://sentry.io/read-the-docs/readthedocs-org/issues/786337892/

@humitos humitos requested a review from Dec 10, 2018
@codecov
Copy link

@codecov codecov bot commented Dec 10, 2018

Codecov Report

Merging #4979 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4979   +/-   ##
======================================
  Coverage    76.8%   76.8%           
======================================
  Files         158     158           
  Lines        9937    9937           
  Branches     1241    1241           
======================================
  Hits         7632    7632           
  Misses       1973    1973           
  Partials      332     332
Impacted Files Coverage Δ
readthedocs/projects/models.py 85.55% <100%> (ø) ⬆️

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Dec 10, 2018

Codecov Report

Merging #4979 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4979   +/-   ##
======================================
  Coverage    76.8%   76.8%           
======================================
  Files         158     158           
  Lines        9937    9937           
  Branches     1241    1241           
======================================
  Hits         7632    7632           
  Misses       1973    1973           
  Partials      332     332
Impacted Files Coverage Δ
readthedocs/projects/models.py 85.55% <100%> (ø) ⬆️

stsewd
stsewd approved these changes Dec 10, 2018
@ericholscher ericholscher merged commit 324a9f0 into master Dec 10, 2018
3 checks passed
@humitos humitos deleted the humitos/project/container-time-limit branch Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants