Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize output and chunk it at DATA_UPLOAD_MAX_MEMORY_SIZE #4982

Merged
merged 2 commits into from Dec 11, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Dec 10, 2018

@humitos humitos requested a review from Dec 10, 2018
@humitos humitos force-pushed the humitos/command/chunk-output branch from cd8c0ba to ceebf39 Dec 10, 2018
before sending it over the API and get a 400.
@humitos humitos force-pushed the humitos/command/chunk-output branch from ceebf39 to ffe4d49 Dec 10, 2018
@codecov
Copy link

@codecov codecov bot commented Dec 10, 2018

Codecov Report

Merging #4982 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #4982      +/-   ##
==========================================
- Coverage    76.8%   76.77%   -0.03%     
==========================================
  Files         158      158              
  Lines        9937     9948      +11     
  Branches     1241     1243       +2     
==========================================
+ Hits         7632     7638       +6     
- Misses       1973     1976       +3     
- Partials      332      334       +2
Impacted Files Coverage Δ
readthedocs/doc_builder/environments.py 86.27% <50%> (-0.79%) ⬇️
readthedocs/vcs_support/backends/git.py 81.98% <0%> (-0.3%) ⬇️
readthedocs/projects/models.py 85.55% <0%> (ø) ⬆️

stsewd
stsewd approved these changes Dec 10, 2018
@humitos
Copy link
Member Author

@humitos humitos commented Dec 11, 2018

@stsewd thanks for the review! Since it's sensitive change, I'd like to wait for another review from the core team before merging.

@readthedocs readthedocs deleted a comment from codecov bot Dec 11, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Looks good. I'm curious how many of these we get -- perhaps we should log something about the project name and build step or something? I doubt we'll do anything about it, so happy to just hack it and be done also.

@humitos
Copy link
Member Author

@humitos humitos commented Dec 11, 2018

perhaps we should log something about the project name and build step or something?

Wow! I missed this. I 👍 on logging. I'm sending a new commit with this change. Thanks to raise this up!

@humitos humitos merged commit 863cb91 into master Dec 11, 2018
1 of 3 checks passed
@humitos humitos deleted the humitos/command/chunk-output branch Dec 11, 2018
@agjohnson agjohnson restored the humitos/command/chunk-output branch Dec 12, 2018
@stsewd stsewd deleted the humitos/command/chunk-output branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants