Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LOCAL_GIT_BRANCHES from settings #4993

Merged
merged 2 commits into from Dec 13, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Dec 12, 2018

Closes #4985

@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 12, 2018

This is only needed with branches, tags are fine.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 12, 2018

Python2 again :(

@codecov
Copy link

@codecov codecov bot commented Dec 12, 2018

Codecov Report

Merging #4993 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4993      +/-   ##
==========================================
- Coverage   76.76%   76.74%   -0.02%     
==========================================
  Files         158      158              
  Lines        9953     9951       -2     
  Branches     1245     1244       -1     
==========================================
- Hits         7640     7637       -3     
  Misses       1980     1980              
- Partials      333      334       +1
Impacted Files Coverage Δ
readthedocs/vcs_support/backends/git.py 81.13% <ø> (-0.86%) ⬇️

@readthedocs readthedocs deleted a comment from codecov bot Dec 12, 2018
@stsewd stsewd requested a review from Dec 12, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 12, 2018

Failure is only related to global coverage

Copy link
Member

@ericholscher ericholscher left a comment

Thanks for doing this. I probably should have figured out how to do it at the time, but this is a better solution than I had :)

@ericholscher ericholscher merged commit 00303bb into readthedocs:master Dec 13, 2018
2 of 3 checks passed
Copy link
Member

@humitos humitos left a comment

Excellent! I like those comments in the code ;)

We could make those 3 steps a method or a function maybe if we think that we are going to use it normally.

@stsewd stsewd deleted the remove-local-git-branches branch Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants