Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor remove_dir #4994

Merged
merged 5 commits into from Jan 14, 2019
Merged

Refactor remove_dir #4994

merged 5 commits into from Jan 14, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Dec 13, 2018

Closes #4297

@codecov
Copy link

@codecov codecov bot commented Dec 13, 2018

Codecov Report

Merging #4994 into master will decrease coverage by <.01%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #4994      +/-   ##
==========================================
- Coverage   76.76%   76.75%   -0.01%     
==========================================
  Files         158      158              
  Lines        9953     9951       -2     
  Branches     1245     1245              
==========================================
- Hits         7640     7638       -2     
  Misses       1980     1980              
  Partials      333      333
Impacted Files Coverage Δ
readthedocs/builds/models.py 78.83% <0%> (ø) ⬆️
readthedocs/projects/views/private.py 80.05% <100%> (ø) ⬆️
readthedocs/projects/admin.py 91.5% <100%> (ø) ⬆️
readthedocs/projects/tasks.py 71.08% <50%> (-0.12%) ⬇️
readthedocs/core/views/__init__.py 71.01% <50%> (ø) ⬆️

@codecov
Copy link

@codecov codecov bot commented Dec 13, 2018

Codecov Report

Merging #4994 into master will decrease coverage by 0.1%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #4994      +/-   ##
==========================================
- Coverage   76.85%   76.75%   -0.11%     
==========================================
  Files         158      158              
  Lines        9991     9951      -40     
  Branches     1254     1245       -9     
==========================================
- Hits         7679     7638      -41     
- Misses       1978     1980       +2     
+ Partials      334      333       -1
Impacted Files Coverage Δ
readthedocs/builds/models.py 78.83% <0%> (ø) ⬆️
readthedocs/projects/views/private.py 80.05% <100%> (+0.41%) ⬆️
readthedocs/projects/admin.py 91.5% <100%> (ø) ⬆️
readthedocs/projects/tasks.py 71.08% <50%> (+0.6%) ⬆️
readthedocs/core/views/__init__.py 71.01% <50%> (+0.42%) ⬆️
readthedocs/vcs_support/backends/svn.py 29.5% <0%> (-9.89%) ⬇️
readthedocs/core/utils/__init__.py 74.73% <0%> (-5.68%) ⬇️
readthedocs/vcs_support/backends/git.py 81.98% <0%> (-1.93%) ⬇️
readthedocs/projects/querysets.py 80.58% <0%> (-0.9%) ⬇️
readthedocs/projects/forms.py 79.66% <0%> (-0.34%) ⬇️
... and 9 more

@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 13, 2018

Believe #4895 will help with the coverage here

readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
Copy link
Member

@ericholscher ericholscher left a comment

Fixed my comment in a commit, think this is good to go.

readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit 33ed273 into readthedocs:master Jan 14, 2019
1 of 2 checks passed
@stsewd stsewd deleted the refactor-remove-dir branch Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants