Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak sidebar ad priority #5005

Merged
merged 1 commit into from Dec 17, 2018
Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Dec 14, 2018

This is a tweak to increase the sidebar ad priority (vs footer ad priority) if the sidebar isn't long. Essentially, this change will prioritize showing a sidebar ad if the sidebar ad would be visible.

@davidfischer davidfischer requested a review from Dec 14, 2018
Copy link
Member

@humitos humitos left a comment

If I understand correctly, we check

  • if the ad is currently displayed/showed on the screen
    • no: lower the priority
    • yes: and it's not a mobile hit, put the maximum priority

If so, this makes sense to me.

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Dec 17, 2018

If I understand correctly, we check

This is correct. Basically if the sidebar ad would be in view, raise the priority of choosing a sidebar ad. If the sidebar ad would require scrolling to see, instead lower the priority. Most likely we'll choose a footer ad.

@davidfischer davidfischer merged commit a109560 into master Dec 17, 2018
2 checks passed
@davidfischer davidfischer deleted the davidfischer/prioritize-sidebar-ads branch Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants