Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More hints for invalid submodules #5012

Merged
merged 3 commits into from Dec 26, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Dec 17, 2018

Now we are showing which submodules need to be fixed.

Related to #4043

)
check_output(['git', 'add', '.'], env=env)
check_output(['git', 'commit', '-m"Add submodule"'], env=env)

# Add a relative submodule URL in the relativesubmodule branch
check_output(['git', 'checkout', '-b', 'relativesubmodule', 'master'], env=env)
Copy link
Member Author

@stsewd stsewd Dec 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't creating the submodule as expected, and we have add_submodule_without_cloning now.

Loading

Copy link
Member Author

@stsewd stsewd Dec 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous test was passing bc we were creating the branch from one that already had a submodule

Loading

@stsewd stsewd requested a review from Dec 17, 2018
Copy link
Member

@humitos humitos left a comment

I like this changes. It will help users to know the problem without filling an issue ;)

Loading

readthedocs/rtd_tests/utils.py Outdated Show resolved Hide resolved
Loading
readthedocs/vcs_support/backends/git.py Show resolved Hide resolved
Loading
@ericholscher ericholscher merged commit 47ea3f3 into readthedocs:master Dec 26, 2018
2 checks passed
Loading
@stsewd stsewd deleted the more-hints-invalid-submodules branch Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants