Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default_branch value from Version.slug to Version.identifier #5034

Merged

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Dec 24, 2018

Fixes #5032

@humitos humitos requested a review from Dec 24, 2018
Copy link
Member

@humitos humitos left a comment

Changes look good to me. Thanks!

I tested this locally with my example of "project not building because of this issue" and it did work.

stsewd
stsewd approved these changes Dec 26, 2018
Copy link
Member

@stsewd stsewd left a comment

I did a grep on the project, I can confirm that we use identifier when accessing to default_branch

@ericholscher ericholscher merged commit f7926c4 into readthedocs:master Dec 26, 2018
2 checks passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Dec 26, 2018

Makes sense. The identifier is the VCS concept, and slugs might be weird because we change them :)

@dojutsu-user dojutsu-user deleted the change-slug-to-identifier branch Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants