Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception in failed checkout #5035

Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Dec 24, 2018

Closes #5033

@stsewd stsewd requested a review from Dec 24, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 24, 2018

Failure is bc we don't have tests for bzr

Copy link
Member

@humitos humitos left a comment

Looks good!

Left some comments to consider.

readthedocs/rtd_tests/tests/test_backend.py Outdated Show resolved Hide resolved
@@ -47,6 +47,10 @@ class RepositoryError(BuildEnvironmentError):
'You can not have two versions with the name latest or stable.'
)

FAILED_TO_CHECKOUT = _(
'Failed to checkout revision: {}'
Copy link
Member

@humitos humitos Dec 26, 2018

Will this exception log to Sentry? It should not.

Copy link
Member Author

@stsewd stsewd Dec 26, 2018

I don't think so. Actually I'm not sure, I haven't seen a RepositoryError in sentry

Copy link
Member

@ericholscher ericholscher Jan 10, 2019

Going to merge this, and if it logs, we can handle it later.

@stsewd stsewd requested a review from Jan 7, 2019
Copy link
Member

@ericholscher ericholscher left a comment

This is a good change. 👍 We can adjust later if we hit issues with it.

@@ -47,6 +47,10 @@ class RepositoryError(BuildEnvironmentError):
'You can not have two versions with the name latest or stable.'
)

FAILED_TO_CHECKOUT = _(
'Failed to checkout revision: {}'
Copy link
Member

@ericholscher ericholscher Jan 10, 2019

Going to merge this, and if it logs, we can handle it later.

@ericholscher ericholscher merged commit 9a58ef4 into readthedocs:master Jan 10, 2019
1 of 2 checks passed
@stsewd stsewd deleted the raise-exception-failed-checkout branch Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants