Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress progress bar of the conda command. #5094

Merged
merged 3 commits into from Jan 14, 2019
Merged

Conversation

@rainwoodman
Copy link
Contributor

@rainwoodman rainwoodman commented Jan 11, 2019

The progress bar generates too much output, may be the cause of failure in #5093.

The progress bar generates too much output, may be the cause of failure in readthedocs#5093.
@rainwoodman
Copy link
Contributor Author

@rainwoodman rainwoodman commented Jan 11, 2019

Somehow who is capable about pip shall look into the q argument of pip installed packages, which may suffer from the same issue.

@jorisvandenbossche
Copy link

@jorisvandenbossche jorisvandenbossche commented Jan 13, 2019

I was just searching for an issue about this (or to open one myself), because I was having the same problem of truncated output. This indeed makes it difficult to see if everything was successful or not.

Copy link
Member

@humitos humitos left a comment

Awesome! Thanks for the contribution.

Please, could you fix the tests? I'm happy to merge after that.

The tests were trying to match the exact commandlines.
@rainwoodman
Copy link
Contributor Author

@rainwoodman rainwoodman commented Jan 13, 2019

Let's see if this fix works.

The test seems to be more strict than asserting the functionality, but I guess there are no better alternatives in this situation.

Copy link
Member

@humitos humitos left a comment

I'm on the fence after talking a look how the --quiet affects the conda env command. I'd like another @rtfd/core to review this and give him opinion.

I believe this is the direction to go though, because we will later add #5006 in the end so, we will have a complete list of what's installed in the environment.

@@ -355,6 +355,7 @@ def setup_base(self):
'conda',
'env',
'create',
'--quiet',
Copy link
Member

@humitos humitos Jan 14, 2019

I think we don't want --quiet here. It made sense the first time I read the docs, but @jorisvandenbossche made me realized that it does not show all the packages installed either (only when called with conda env). More discussion here #5099 (comment)

Note that without --quiet, it also does not show all the packages installed. It only shows the download progress output. In some way you can derive from that the installed packages, but only for short package names (otherwise the name and certainly the version is truncated), and it is also in a very unreadable way (compared to conda list or the way conda create lists the packages to be installed).
So given that, I would personally still be in favor of using --quiet here, as it simply removes somewhat non-useful output.

See eg the output of the conda env create step in https://readthedocs.org/projects/geopandas/builds/8384815/: for quite some of the packages in the download progress, you can't see the full version, and for some not even the full package name.

Copy link
Member

@humitos humitos Jan 14, 2019

You are right!

So, merging this since it's the right direction to go. I'd love a contribution of #5099 soon, so we complete this output :)

@humitos humitos requested a review from Jan 14, 2019
@humitos humitos merged commit b07f455 into readthedocs:master Jan 14, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants