Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common pieces #5095

Merged
merged 1 commit into from Jan 13, 2019
Merged

Fix common pieces #5095

merged 1 commit into from Jan 13, 2019

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Jan 12, 2019

The submodule changed and wasn't updated here, so things were broken.
I didn't author changes to common, so not sure if everything is safe to
bring in.

The submodule changed and wasn't updated here, so things were broken.
I didn't author changes to common, so not sure if everything is safe to
bring in.
@agjohnson agjohnson added the Bug label Jan 12, 2019
@agjohnson agjohnson requested a review from Jan 12, 2019
@agjohnson agjohnson added this to the 2.9 milestone Jan 12, 2019
Copy link
Member

@humitos humitos left a comment

Good!

Changes from common introduce the new invoke tasks and re-order of them.

@humitos humitos merged commit 080deb5 into master Jan 13, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the agj/fix-broken-common branch Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants