Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not list banned projects under /projects/ #5097

Merged
merged 3 commits into from Jan 22, 2019

Conversation

@humitos
Copy link
Member

@humitos humitos commented Jan 12, 2019

Going to https://readthedocs.org/projects/ you will see many SPAM projects from users that we already banned in our db.

This PR skip showing those projects publicly.

NOTE: this is not ready to merge yet, since I think it may worth to implement it directly into the .public and .private method of the ProjectQuerySetBase but I want a little of feedback on this first.

@humitos humitos requested a review from Jan 12, 2019
@stsewd
Copy link
Member

@stsewd stsewd commented Jan 14, 2019

Makes sense for me to not list banned projects anywhere

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 14, 2019

I guess my larger question is, should we still have project listings? We don't link it, and it doesn't seem to have much value.

If we're trying to hide spam projects, I think search is likely the most important place to hide them.

@humitos
Copy link
Member Author

@humitos humitos commented Jan 14, 2019

I guess my larger question is, should we still have project listings? We don't link it, and it doesn't seem to have much value.

I would completely remove it since it's just a plain list with no value added.

On the other hand, what about my note from the description. Does it worth to that the filter of banned project to all the queries from that QuerySet?

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 15, 2019

I would completely remove it since it's just a plain list with no value added.

👍

On the other hand, what about my note from the description. Does it worth to that the filter of banned project to all the queries from that QuerySet?

I think it makes sense. There may be unindented issues, but I'm 👍 on trying it. = That would likely help with indexing of search results (and not building the projects will keep the files out of search)

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 22, 2019

Merging this, since I think it's useful, and opened #5152 for further work.

@humitos humitos merged commit 3304193 into master Jan 22, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the humitos/do-not-list-banned-projects branch Jan 22, 2019
@humitos
Copy link
Member Author

@humitos humitos commented Jan 22, 2019

Hrm... I just merged this PR with the PR: work in progress label. It seems that mergeable ProBot bot is not installed properly yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants