Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from config module #5116

Merged
merged 1 commit into from Jan 17, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jan 15, 2019

DOCKER_IMAGE_SETTINGS has the same value as env_config.
It is used to update the python version supported for that image, but both have the same value, so it's redundant.

Related https://github.com/rtfd/readthedocs.org/pull/5056/files#r247609367

`DOCKER_IMAGE_SETTINGS` has the same value as `env_config`.
It is used to update the python version supported for that image.
if 'DOCKER_IMAGE_SETTINGS' in self.env_config and \
build['image'] in self.env_config['DOCKER_IMAGE_SETTINGS']:
self.env_config.update(
self.env_config['DOCKER_IMAGE_SETTINGS'][build['image']]
Copy link
Member Author

@stsewd stsewd Jan 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already updated above (lines 403..407)

Loading

@stsewd stsewd requested a review from Jan 16, 2019
@stsewd stsewd merged commit d196fc7 into readthedocs:master Jan 17, 2019
2 checks passed
Loading
@stsewd stsewd deleted the remove-dead-code-config-module branch Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants