Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local-docs-build requirements #5136

Merged
merged 1 commit into from Jan 21, 2019
Merged

Fix local-docs-build requirements #5136

merged 1 commit into from Jan 21, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 21, 2019

Our docs are currently not building because they depend on
the RTD app being installed properly to import strings.
This fixes the local-docs-build.txt file to include the proper requirements

Our docs are currently not building because they depend on
the RTD app being installed properly to import strings.
This fixes the local-docs-build.txt file to include the proper requirements
@ericholscher ericholscher requested a review from humitos Jan 21, 2019
@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Jan 21, 2019

@ericholscher
Can travis be configured to detect this?
This bug was introduced by me on PR #5100 😟

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jan 21, 2019

RTD should have PR support, and it would have detected it :(

Copy link
Member

@humitos humitos left a comment

Changes are good to fix this problem.

Although, I still think it's possible to split requirements in one file more docs that install only what's needed (including only needed packages from app).

@ericholscher ericholscher merged commit 28845c7 into master Jan 21, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-docs-build branch Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants