Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin functions for wiping a version #5140

Merged
merged 11 commits into from Feb 26, 2019

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Jan 21, 2019

Closes #3684

@agjohnson agjohnson added this to the Site admin features milestone Jan 22, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Currently this breaks in testing.
screenshot 2019-01-29 17 00 40


def wipe_version_via_slug(version_slug):
"""Wipes the given version."""
version = get_object_or_404(Version, slug=version_slug)
Copy link
Member

@ericholscher ericholscher Jan 29, 2019

This needs to be filtering by a project, not just a version slug.

Copy link
Member Author

@dojutsu-user dojutsu-user Jan 30, 2019

Okay.
I have pushed the changes.

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Jan 30, 2019

@ericholscher
I have pushed the changes suggested by you.

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Feb 21, 2019

@ericholscher
I have added one more test.
Can this PR get another round of review?

Copy link
Member

@ericholscher ericholscher left a comment

Looks good. 👍

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 26, 2019

Thanks!

@ericholscher ericholscher merged commit bba018d into readthedocs:master Feb 26, 2019
1 check passed
@dojutsu-user dojutsu-user deleted the admin-action-for-version branch Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants