Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade recommonmark to latest and fix integration #5146

Merged
merged 2 commits into from Jan 22, 2019
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 22, 2019

Closes readthedocs/common#29

@ericholscher ericholscher requested a review from Jan 22, 2019
@ericholscher ericholscher added this to the 2.9 milestone Jan 22, 2019
@@ -20,5 +20,5 @@ sphinx-prompt==1.0.0

# commonmark 0.5.5 is the latest version compatible with our docs, the
# newer ones make `tox -e docs` to fail
commonmark==0.5.5
Copy link
Member

@stsewd stsewd Jan 22, 2019

We can remove the above comment now

Copy link
Member Author

@ericholscher ericholscher Jan 22, 2019

Done!

stsewd
stsewd approved these changes Jan 22, 2019
@ericholscher ericholscher merged commit 1d1dc8b into master Jan 22, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the fix-recommonmark branch Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants