Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sphinx conf.py inserts #5150

Merged
merged 3 commits into from Jan 22, 2019
Merged

Fix Sphinx conf.py inserts #5150

merged 3 commits into from Jan 22, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 22, 2019

These were breaking builds:

ConfigError: There is a syntax error in your configuration file: from __future__ imports must occur at the beginning of the file (conf.py, line 45)

These configs were working fine on Python 2 and 3 builds previously,
I don't think they need to be changed.

Reverts 06b07cc#diff-6a827604d651f579d03b359bbcd495e3R16

Fix #5148

@ericholscher ericholscher requested a review from Jan 22, 2019
@ericholscher ericholscher force-pushed the fix-conf-py-insert branch from fb9421e to 76bdfc8 Jan 22, 2019
stsewd
stsewd approved these changes Jan 22, 2019
@ericholscher ericholscher merged commit 92563df into master Jan 22, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the fix-conf-py-insert branch Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants