Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort versions smartly everywhere #5157

Merged
merged 2 commits into from Jan 23, 2019

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Jan 23, 2019

Closes #5151

It wasn't possible to use the sort_version_compare only on the template level. So, I have also used it in view and forms level.

@@ -1,6 +1,8 @@
{% load projects_tags %}

<div class="module-list-wrapper">
Copy link
Member Author

@dojutsu-user dojutsu-user Jan 23, 2019

I didn't find any use case for this file.
Can it be deleted?

Copy link
Member

@ericholscher ericholscher Jan 23, 2019

Hrm, I think so!

@humitos humitos requested a review from Jan 23, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Looks good. Should be good to merge after deleting unused file.

@@ -1,6 +1,8 @@
{% load projects_tags %}

<div class="module-list-wrapper">
Copy link
Member

@ericholscher ericholscher Jan 23, 2019

Hrm, I think so!

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Jan 23, 2019

@ericholscher
Deleted the unused file.

@ericholscher ericholscher merged commit d351c21 into readthedocs:master Jan 23, 2019
1 check passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 23, 2019

💯 Thanks @dojutsu-user!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants