Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs reformatting with :guilabel: #5161

Merged
merged 7 commits into from Feb 12, 2019

Conversation

@rexzing
Copy link
Contributor

@rexzing rexzing commented Jan 23, 2019

Refactoring the docs by replacing Admin menu guidance with :guilabel: sphinx role for all the docs. This is a fix to issue #5137

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Jan 23, 2019

Thanks @rexzing 🎉
Someone from the core team will review this.

Copy link
Member

@stsewd stsewd left a comment

Thanks for the contribution! Just requesting some minor changes.

docs/advertising/ethical-advertising.rst Outdated Show resolved Hide resolved
docs/guides/build-notifications.rst Outdated Show resolved Hide resolved
docs/guides/build-notifications.rst Outdated Show resolved Hide resolved
docs/webhooks.rst Outdated Show resolved Hide resolved
docs/webhooks.rst Outdated Show resolved Hide resolved
@rexzing
Copy link
Contributor Author

@rexzing rexzing commented Jan 24, 2019

Sure... I will do these changes.

@rexzing
Copy link
Contributor Author

@rexzing rexzing commented Jan 25, 2019

Should I close this PR and send a new one or is there a way to add changes to this PR?

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Jan 25, 2019

You can checkout on this branch, make and commit changes and then push them.
It will appear here.
No need of new PR.

@rexzing
Copy link
Contributor Author

@rexzing rexzing commented Jan 25, 2019

I added the requested changes

docs/webhooks.rst Outdated Show resolved Hide resolved
Copy link
Member

@humitos humitos left a comment

Excellent! Thanks.

@ericholscher ericholscher dismissed stale reviews from humitos and stsewd via 2ec2bba Feb 12, 2019
@ericholscher ericholscher merged commit 76972df into readthedocs:master Feb 12, 2019
1 check was pending
@rexzing rexzing deleted the guilabel-reformatting branch Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants