Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 'more info' link in admin settings page #5180

Merged
merged 3 commits into from Feb 12, 2019

Conversation

@EJEP
Copy link
Contributor

@EJEP EJEP commented Jan 26, 2019

Change the 'more info' link in the admin settings page to be more clear that the link is for more information on the sphinx options. Resolves #5175

@stsewd
Copy link
Member

@stsewd stsewd commented Jan 28, 2019

Thanks, makes sense for me. We need to add a migration for this change.

@EJEP
Copy link
Contributor Author

@EJEP EJEP commented Feb 2, 2019

I assume I don't need to do anything for that to happen?

@stsewd
Copy link
Member

@stsewd stsewd commented Feb 2, 2019

You need to run the django makemigrations command

https://docs.djangoproject.com/en/1.11/ref/django-admin/#django-admin-makemigrations

python manage.py makemigrations --name update-doctype-helptext

@stsewd
Copy link
Member

@stsewd stsewd commented Feb 2, 2019

Can you please rebase/merge against master? So mergeable doesn't fail.

@EJEP
Copy link
Contributor Author

@EJEP EJEP commented Feb 2, 2019

I've merged master in

@EJEP
Copy link
Contributor Author

@EJEP EJEP commented Feb 2, 2019

I should say that I have generated a migration as well

stsewd
stsewd approved these changes Feb 3, 2019
@ericholscher ericholscher merged commit a0b59fe into readthedocs:master Feb 12, 2019
1 of 2 checks passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants