Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow source_suffix to be a dictionary #5183

Merged
merged 1 commit into from Jan 28, 2019

Conversation

@humitos
Copy link
Member

@humitos humitos commented Jan 28, 2019

Sphinx >= 1.8 supports a dictionary for source_suffix:

https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-source_suffix

Once merged and deploy, this build should pass: https://readthedocs.org/projects/test-builds/builds/8459471/

I tested this locally and that project builds properly.

@humitos humitos requested a review from Jan 28, 2019
@humitos
Copy link
Member Author

@humitos humitos commented Jan 28, 2019

mergeable app fails with a problem on its configuration but I don't find the error. On the other hand, it seems they release version: 2 of its file so new docs are different.

stsewd
stsewd approved these changes Jan 28, 2019
@ericholscher ericholscher merged commit 8c59b23 into master Jan 28, 2019
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the humitos/support-mapping-suffix branch Jan 28, 2019
@mikkeloscar
Copy link

@mikkeloscar mikkeloscar commented Feb 5, 2019

I still see the problem on this build: https://readthedocs.org/projects/kubernetes-on-aws/builds/8515774/ The new changes are not injected in the conf.py. Do I need to enable anything to get the latest change?

@stsewd
Copy link
Member

@stsewd stsewd commented Feb 5, 2019

@mikkeloscar this change isn't deployed yet

@mikkeloscar
Copy link

@mikkeloscar mikkeloscar commented Feb 5, 2019

:( any idea on when it will be deployed? (I assumed it was because the issue was closed :))

@stsewd
Copy link
Member

@stsewd stsewd commented Feb 5, 2019

Maybe this week or the next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants