Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove approvals requirement from mergable #5200

Merged
merged 3 commits into from Jan 30, 2019
Merged

Remove approvals requirement from mergable #5200

merged 3 commits into from Jan 30, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 30, 2019

This just causes every PR to fail, which is terrible UX.

@ericholscher ericholscher requested a review from Jan 30, 2019
@stsewd
Copy link
Member

@stsewd stsewd commented Jan 30, 2019

I think there is a setting inside github to force approvals before merge

Loading

@stsewd
Copy link
Member

@stsewd stsewd commented Jan 30, 2019

There it is

screenshot_2019-01-30 stsewd dotfiles

Loading

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jan 30, 2019

Set it to require one review 👍

Loading

min:
count: 1
message: 'The PR must have a minimum of 1 approvals.'
# Removed because it causes every PR to fail
Copy link
Member

@stsewd stsewd Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can just remove this lines since we have set up this from github

Loading

stsewd
stsewd approved these changes Jan 30, 2019
@humitos
Copy link
Member

@humitos humitos commented Jan 30, 2019

For labels, I think we should add in must_exclude the label Status: blocked also.

Loading

@ericholscher ericholscher merged commit 0818219 into master Jan 30, 2019
1 of 2 checks passed
Loading
@delete-merged-branch delete-merged-branch bot deleted the fix-mergable branch Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants