Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update search on HTMLFile save #5244

Merged
merged 2 commits into from Feb 6, 2019
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 6, 2019

This causes a huge number of HTMLFile index updates to happen on doc building.
We already have logic to index HTMLFile's in bulk during builds,
so we don't need this.

https://github.com/rtfd/readthedocs.org/blob/b95c1feb308fe8bcc3705139cebb2f9f3d32f75c/readthedocs/projects/tasks.py#L1193-L1195

This causes a huge number of HTMLFile index updates to happen on doc building.
We already have logic to index HTMLFile's in bulk during builds,
so we don't need this.
Copy link
Contributor

@agjohnson agjohnson left a comment

This makes sense to me, we're triggering a lot of tasks with these signals. I don't feel super comfortable commenting on whether these signals are actually technically needed or not however, so take my feedback in moderation on this one.

@safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Feb 6, 2019

Looks good! R+

@ericholscher ericholscher merged commit a083eca into master Feb 6, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the hotfix-htmlfile-save-signals branch Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants