Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t delay search delete on project delete #5262

Merged
merged 1 commit into from Feb 11, 2019
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 11, 2019

This was causing an issue where we were trying to delete a project that didn’t exist, so it wasn’t getting removed from the index properly. It should be done in process, otherwise it’s a race condition.

This was causing an issue where we were trying to delete a project that didn’t exist, so it wasn’t getting removed from the index properly. It should be done in process, otherwise it’s a race condition.
@ericholscher ericholscher requested a review from Feb 11, 2019
Copy link
Member

@humitos humitos left a comment

Makes sense to me considering that we are already inside a task and how the query is performed inside delete_objects_in_es.

In other simpler cases, we were passing everything that it's needed for the task as arguments to avoid querying the db for a non-existent object.

@ericholscher ericholscher merged commit 6fa0dd3 into master Feb 11, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the fix-search-delete branch Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants