Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extensions to control URL structure #5296

Merged
merged 1 commit into from Feb 19, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Feb 15, 2019

  • Adds a setting that can be checked if the RTD extensions are available
  • If the extensions are available, they can control their own URL structure
- Only executed if the extensions are importable
@davidfischer davidfischer requested a review from Feb 15, 2019
Copy link
Member

@ericholscher ericholscher left a comment

This feels cleaner, and keeps the logic out of the main codebase. 👍

We should also remove the other places we're doing similar logic, I believe https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/restapi/urls.py#L118 is perhaps the only other.

@ericholscher ericholscher merged commit 01347ab into master Feb 19, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/extensions-control-urls branch Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants