Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup a little of documentation_type from footer #5315

Merged
merged 1 commit into from Feb 27, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Feb 20, 2019

This doesn't remove documentation_type completely from
the footer, but makes it more clear what we are really using.

We don't use readthedocssinglehtml as proven in readthedocs/readthedocs-sphinx-ext#58
We don't set page for mkdocs projects: https://github.com/rtfd/readthedocs.org/blob/f1c15d4f22af0ba7ebf762df1d49f7c28e8d01e5/readthedocs/doc_builder/backends/mkdocs.py#L207-L207

Ref #4638

This doesn't remove documentation_type completely from
the footer, but makes it more clear what we are really using.

We don't use `readthedocssinglehtml` as proven in readthedocs/readthedocs-sphinx-ext#58
We don't set `page` for mkdocs projects: https://github.com/rtfd/readthedocs.org/blob/f1c15d4f22af0ba7ebf762df1d49f7c28e8d01e5/readthedocs/doc_builder/backends/mkdocs.py#L207-L207

Ref readthedocs#4638
@stsewd stsewd requested a review from Feb 20, 2019
@humitos
Copy link
Member

@humitos humitos commented Feb 20, 2019

I don't have enough context to review this PR.

From what I can read, we are defining path to ends with / for sphinx_htmldir and .html otherwise. Why do you mention page in the description if the logic we are changing here is around path instead?

@stsewd
Copy link
Member Author

@stsewd stsewd commented Feb 20, 2019

Copy link
Member

@ericholscher ericholscher left a comment

Simple enough. 👍

@ericholscher ericholscher merged commit 4534d62 into readthedocs:master Feb 27, 2019
1 check passed
@stsewd stsewd deleted the cleanup-doctype-from-footer branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants