Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require conda.file when using conda in v1 #5338

Merged
merged 2 commits into from Feb 22, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Feb 22, 2019

Some people are migrating from pip to conda,
but they were using a v1 config,
then when migrating they are using the conda option from v2 (which is called conda.environment)

We are not validating this, but using conda.file is mandatory
when using the conda option in v1 (or rtd will fail without any reason).

Close #5322
Close #5228

Some people are migrating from pip to conda,
but they were using a v1 config,
then when migrating they are using the conda option from v2.

We are not validating this, but using conda.file is mandatory
when using the conda option (or rtd will fail without any reason).

Close readthedocs#5322
Close readthedocs#5228
@stsewd stsewd requested a review from Feb 22, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Makes sense. Over time we should start warning users on the build page who are using v1, and tell them to upgrade.

@ericholscher ericholscher merged commit 86bfdff into readthedocs:master Feb 22, 2019
1 check passed
@stsewd stsewd deleted the require-file-when-using-conda branch Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants