Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest warnings #5346

Merged
merged 4 commits into from Mar 5, 2019
Merged

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Feb 23, 2019

As i wasn't able to pass the request Fixture to the setUp() method I have Done it Like this Please Let Me know if There is a better implementation.
closes #5300

conftest.py Outdated Show resolved Hide resolved
Copy link
Member

@safwanrahman safwanrahman left a comment

This looks good to me. r+
@humitos It should get merged. What do you think?

stsewd
stsewd approved these changes Mar 5, 2019
@stsewd
Copy link
Member

@stsewd stsewd commented Mar 5, 2019

Thanks

@stsewd stsewd merged commit bdb4aa5 into readthedocs:master Mar 5, 2019
1 check passed
@saadmk11 saadmk11 deleted the remove-pytest-warnings branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants