Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx domain models and migrations #5363

Merged
merged 3 commits into from Feb 27, 2019
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 27, 2019

This will go out as a hotfix for the deploy.

Copy link
Member

@stsewd stsewd left a comment

Wow, just realized we didn't have the migrations, we need to add more tests for this I think p:

Loading

('display_name', models.CharField(max_length=255, verbose_name='Display Name')),
('type', models.CharField(max_length=255, verbose_name='Type')),
('doc_name', models.CharField(max_length=255, verbose_name='Doc Name')),
('anchor', models.CharField(max_length=255, verbose_name='Anchor')),
Copy link
Member

@stsewd stsewd Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max-length isn't reflected in the migration file

Loading

Copy link
Member Author

@ericholscher ericholscher Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to push the 2nd migration. Need it for prod.

Loading

stsewd
stsewd approved these changes Feb 27, 2019
@ericholscher ericholscher merged commit 439e8af into master Feb 27, 2019
1 check was pending
Loading
@delete-merged-branch delete-merged-branch bot deleted the fix-sphinx-domain-migrations branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants