Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'default_version` field as readonly if no active versions are found. #5374

Merged
merged 1 commit into from Mar 14, 2019

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Feb 28, 2019

If there are no active versions of a project, an error is raised when Advanced Settings page is accessed.

screenshot from 2019-02-28 22-06-55

screenshot from 2019-02-28 22-46-15

@stsewd
Copy link
Member

@stsewd stsewd commented Feb 28, 2019

Looks like always expect a value there

https://github.com/rtfd/readthedocs.org/blob/4737c835c9ba039c39a83204179060e329446c21/readthedocs/projects/models.py#L146-L151

What happens if the user tries to save the form?

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Feb 28, 2019

@stsewd
The value is set to latest only. Only the field is made readonly.

screenshot from 2019-03-01 00-51-22

After saving the form, build is triggered and successful but http://localhost:8000/docs/requests-test/en/latest/ results to 404

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Mar 7, 2019

@ericholscher
As sentry logs are hidden from me .. can you please update me as what needs to be done here.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 14, 2019

Mostly I was just saying it's a priority because users are hitting it, which is a really bad UX :)

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Mar 14, 2019

This was introduced by me in #5157.
I am sorry for it.

@ericholscher ericholscher merged commit 0bfccf1 into readthedocs:master Mar 14, 2019
1 check passed
@dojutsu-user dojutsu-user deleted the no-active-version branch Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants