Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative paths in config module #5377

Merged
merged 4 commits into from May 20, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 1, 2019

Closes #5364

The main change was in readthedocs/config/validation.py, we are really good covered with tests here, and tested it locally, everything keeps working.

@stsewd stsewd requested a review from Mar 1, 2019
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 1, 2019

What is the goal of doing this?

Edit: Ignore me -- I just read the linked ticket.

@stale
Copy link

@stale stale bot commented Apr 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Member

@humitos humitos left a comment

Looks good to me! We should merge and ship it :)

Are we using this data stored in the _config field from the Build for something? I see that we will have two different PATHs now in the DB for this field --will this affect our code?

@stsewd stsewd merged commit 49995aa into readthedocs:master May 20, 2019
1 check passed
@stsewd stsewd deleted the use-relative-paths-in-config-module branch May 20, 2019
@stsewd
Copy link
Member Author

@stsewd stsewd commented May 20, 2019

Are we using this data stored in the _config field from the Build for something?

No really, but we are going to use it to show that info to the user in each build, so they don't need the builder path neither.

stsewd added a commit to stsewd/readthedocs.org that referenced this issue May 31, 2019
After readthedocs#5377
The code calling the config module is in charge of getting the full
path.
@stsewd stsewd mentioned this pull request May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants