Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an application form for community ads #5379

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Mar 1, 2019

My goal is to streamline the process for applying for community ads. Rather than an open ended email, I want to get applications that are immediately actionable.

I'm not sure how people feel about Google Forms, but they seem like a good fit here.

@davidfischer davidfischer requested a review from Mar 1, 2019
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 1, 2019

Looks good. I think you can make the image a file upload form, but it requires users login to Google.

Would be neat to have this built into the ad server and perhaps switch to showing community ads via the ad server first, to slowly spin it up.

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Mar 1, 2019

I think you can make the image a file upload form, but it requires users login to Google.

This is correct. I'd erred on the side of not making users login but if we don't think that's a hurdle, I agree an upload is better.

Would be neat to have this built into the ad server and perhaps switch to showing community ads via the ad server first, to slowly spin it up.

While it would be nice, a community ads application is super specific to Read the Docs. I'm not 100% sure it makes sense in the ad server.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 18, 2019

Shall we ship this, and can iterate if we need?

@davidfischer davidfischer merged commit caa8b6c into master Mar 19, 2019
1 check passed
@davidfischer davidfischer deleted the davidfischer/community-ads-form branch Mar 19, 2019
@humitos
Copy link
Member

@humitos humitos commented Mar 21, 2019

💯 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants