Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed Issue #5327 #5383

Merged
merged 2 commits into from Mar 8, 2019
Merged

Addressed Issue #5327 #5383

merged 2 commits into from Mar 8, 2019

Conversation

@rshrc
Copy link
Contributor

@rshrc rshrc commented Mar 1, 2019

Deleted allow_email and also the function get_contribution_details() function in core/models.py

Close #5327

Deleted allow_email and also the function get_contribution_details() function in core/models.py
Linting problem 1 fixed, pushing to find new error in code
@ericholscher ericholscher requested a review from Mar 5, 2019
humitos
humitos approved these changes Mar 5, 2019
Copy link
Member

@humitos humitos left a comment

Looks good! Thanks.

The PR is marked as "Work in progress", though. Are you still working on it or is it ready to merge?

@rshrc
Copy link
Contributor Author

@rshrc rshrc commented Mar 5, 2019

Yes this is ready to merge. Thanks for the review.

stsewd
stsewd approved these changes Mar 5, 2019
@stsewd stsewd merged commit bb4c639 into readthedocs:master Mar 8, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants