Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal requirements #5396

Merged
merged 4 commits into from Mar 14, 2019
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 4, 2019

Changelogs are in each commit.

I didn't update the mock lib, I don't know what changed. They removed their changelog after 1.0.1 testing-cabal/mock@18c9bbd#diff-1034dffc22980f2f99ec5765e88235fd

Also, I'm not even sure if we need pillow at all

stsewd added 3 commits Mar 4, 2019
There are a lot of changes, but the most relevant
is they drop support for old versions of python
and added support for new ones.

Changelog https://pillow.readthedocs.io/en/stable/releasenotes/index.html
@stsewd stsewd requested review from ericholscher and Mar 4, 2019
@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 4, 2019

I still need to test this locally with some projects.

@stsewd stsewd changed the title Update internal req Update internal requirements Mar 5, 2019
Copy link
Member

@humitos humitos left a comment

Why you didn't update the other ones? commonmark and recommonmark for example.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 5, 2019

We don't have a proper changelog for recommonmark, but seen the commits https://github.com/rtfd/recommonmark/commits/master nothing breaking so far. Just make sure it works p:

For commonmark we have only one breaking change, the packages was renamed, but that was fixed in recomonmark too https://github.com/rtfd/CommonMark-py/blob/master/CHANGELOG.md

@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 5, 2019

Tested some projects and this one using recomonmark https://readthedocs.org/projects/agaric-documentation/ it's passing :)

@stsewd stsewd requested a review from Mar 5, 2019
Copy link
Member

@humitos humitos left a comment

💯

@ericholscher ericholscher merged commit 1b9ed03 into readthedocs:master Mar 14, 2019
1 check passed
@stsewd stsewd deleted the update-internal-req branch Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants