Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove view docs dropdown #5400

Merged
merged 5 commits into from Mar 6, 2019
Merged

Remove view docs dropdown #5400

merged 5 commits into from Mar 6, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 5, 2019

I'll continue @ericholscher's work here

It looks like this

screenshot_2019-03-05 anonymoususer s profile read the docs
screenshot_2019-03-05 home read the docs

ericholscher added 3 commits Mar 5, 2019
This removes it from the:

* User profile page
* Homepage

This caused a significant DB load when a project has a large number of versions,
and is almost certainly never used by users.
They can click the project to get a specific version.
@stsewd stsewd requested a review from Mar 5, 2019
Copy link
Contributor

@agjohnson agjohnson left a comment

I don't think we need to address here, but we should return to this and potentially remove the link to the build list page when a project doesn't have a build. This seems like a strange place to send a user that is on a profile page -- like, they probably don't have the rights to build the project anyways, so way are we pointing users there?

It matches the current implementation, so this is fine for now.

<a href="{{ project.get_docs_url }}">{% trans "View Docs" %}
{% else %}
<a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a>
{% endif %}
Copy link
Contributor

@agjohnson agjohnson Mar 5, 2019

nit: else and endif indentation is wrong.

Copy link
Member Author

@stsewd stsewd Mar 5, 2019

Actually it was missing a </a> :/

humitos
humitos approved these changes Mar 6, 2019
Copy link
Member

@humitos humitos left a comment

Looks good to me!

@humitos
Copy link
Member

@humitos humitos commented Mar 6, 2019

but we should return to this and potentially remove the link to the build list page when a project doesn't have a build

What would be the solution here? Removing the "No docs" button completely and only show "View docs" when there is docs to show?

@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 6, 2019

but we should return to this and potentially remove the link to the build list page when a project doesn't have a build

I guess we can address that in the site redesign

@stsewd stsewd merged commit 4911600 into master Mar 6, 2019
1 check passed
@stsewd stsewd deleted the remove-view-docs-dropdown branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants